Propose Extractor API (#561, Plan A) #562
Conversation
…vl/jupyterlab-lsp into bollwyvl-jupyter-lspgh-561-quick-fix
|
Sorry for the mess in the commits! |
|
I added a minimal package with a simple test to help keep us honest 😬 |
| "lib/**/*.{js,ts}" | ||
| ], | ||
| "dependencies": { | ||
| "@krassowski/jupyterlab-lsp": "^3.4" |
There was a problem hiding this comment.
| "@krassowski/jupyterlab-lsp": "^3.4" | |
| "@krassowski/jupyterlab-lsp": "^3.5" |
Though the versions need to be bumped elsewhere for it to compile I think
There was a problem hiding this comment.
yeah, seems out of scope for this pr...
There was a problem hiding this comment.
sure, can do it later, just noted to remember!
|
still doin' some npm solvin'... |
|
Trying to roll back, but concerned the depedency chain of |
| export const extractor = new RegExpForeignCodeExtractor({ | ||
| language: 'foo', | ||
| pattern: '^%%(foo)( .*?)?\n([^]*)', | ||
| extract_to_foreign: '$3', |
There was a problem hiding this comment.
| extract_to_foreign: '$3', | |
| foreign_capture_groups: [3], |
|
Tests are looking good locally, no further changes planned... |
|
Seeing this locally, too: |
|
Ah, there's some bad entropy... |
|
Current plan (testing locally, before pushing):
|
|
Interactive testing looking good locally. |
|
Cool, some stuff is coming up ✔️ |
|
aside from OSX 3.8 which is crapping out on |
References
#???Code changes
jupyterlab-lsp/index.ts, expose some minimal functional APIs fromjupyterlab-lsp/api/extractor.tsjupyterlab-lsp/api/overrides.ts_example-extractorto test the APIrimrafdependency acrosspackage.jsonsrobotframework 4.0--preserveWatchOutputtowatchUser-facing changes
Backwards-incompatible changes
lib)Chores