Source-aware completions and more completer settings #549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Small step towards #495 and #236. Fixes #492.
Code changes
CompletionHandler.ICompletionItemsReply
to include source information (ICompletionsReply
)ICompletionsSource
for source metadata storageCompletionHandler.ICompletionItem
to include source info and others (IExtendedCompletionItem
)IExtendedCompletionItem
andICompletionsReply
can be null/undefined at different stages. How to handle this safely for future us?User-facing changes
caseSensitive
: old behaviour retained by defaultincludePerfectMatches
: old behaviour retained by defaultlabelExtra
: new behaviour - display detail from LSP rather than the type in the completion labelBackwards-incompatible changes
Chores