Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where getCursor() returns null in highlighter #544

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Handle case where getCursor() returns null in highlighter #544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968b777
Handle case where getCursor() returns null in highlighter
brendan0powers Feb 23, 2021
4893e3e
Clean up null check
bpowers39 Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/jupyterlab-lsp/src/features/highlights.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ export class HighlightsCM extends CodeMirrorIntegration {
return;
}

if (root_position == null) {
this.console.warn('no root position available');
return;
}

const token = this.virtual_editor.get_token_at(root_position);

// if token has not changed, no need to update highlight, unless it is an empty token
Expand Down