Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse paths for files deep in subfolders #524

Merged
merged 3 commits into from
Feb 14, 2021
Merged

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Feb 14, 2021

References

Fixes #515. The full path is displayed upon hovering over the collapsed path:

Screenshot from 2021-02-14 16-41-21

Code changes

  • Added react test for get_breadcrumbs
  • Added code to collapse the breadcrumb path if more than three parts; assumes forward slash as the paths are normalized at this point

User-facing changes

Before:
Screenshot from 2021-02-14 16-28-29

After:
Screenshot from 2021-02-14 16-26-47

Before:
Screenshot from 2021-02-14 16-27-42

After:
Screenshot from 2021-02-14 16-26-16

Backwards-incompatible changes

Adds a "collapse" toggle to get_breadcrumbs

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski krassowski merged commit d6f836e into master Feb 14, 2021
@krassowski krassowski deleted the collapse_long_paths branch February 14, 2021 18:14
@krassowski krassowski added this to the 3.4 milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostics panel shows full path when multiple languages are used
1 participant