Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #516
Code changes
remaining_lifetime
of foreign documents to 6. This is an arbitrary number but it feels right given that we are balancing the benefit of having faster restoration of features if foreign document temporarily stopped matching the regular expression as user is modifying it and the con of the diagnostics in the panel not disappearing immediatelyUser-facing changes
Diagnostics panel will work reliably when removing transclusions/foreign documents
Backwards-incompatible changes
None
Chores