Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/diagnostics panel crash #522

Merged
merged 4 commits into from
Feb 14, 2021
Merged

Fix/diagnostics panel crash #522

merged 4 commits into from
Feb 14, 2021

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Feb 14, 2021

References

Fixes #516

Code changes

  • Added event listener to listen for closure of foreign documents and remove their diagnostics
  • Added a safety net (if + console.warn) in case we get an empty document again for another reason
  • Reduced default remaining_lifetime of foreign documents to 6. This is an arbitrary number but it feels right given that we are balancing the benefit of having faster restoration of features if foreign document temporarily stopped matching the regular expression as user is modifying it and the con of the diagnostics in the panel not disappearing immediately

User-facing changes

Diagnostics panel will work reliably when removing transclusions/foreign documents

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski krassowski merged commit f324c69 into master Feb 14, 2021
@krassowski krassowski deleted the fix/diagnostics-panel-crash branch February 16, 2021 23:22
@krassowski krassowski added this to the 3.4 milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostics panel breaks when foreign cells are removed
1 participant