Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tab-invoked completion in strings, suppress autoinvoke in def #521

Merged
merged 5 commits into from
Feb 14, 2021

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Feb 14, 2021

References

Fixes #514 and point 7 in #495

Code changes

Split suppressInvokeIn setting into suppressContinuousHintingIn and suppressTriggerCharacterIn; added missing condition checks.

User-facing changes

Completion in strings (keys of dict) works.

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski krassowski merged commit a7f07c6 into master Feb 14, 2021
@krassowski krassowski deleted the completion/model-and-sorting branch February 16, 2021 23:22
@krassowski krassowski added this to the 3.4 milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local string completion blocked by extension
1 participant