Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More backports to 2.x #499

Merged
merged 6 commits into from
Feb 1, 2021
Merged

More backports to 2.x #499

merged 6 commits into from
Feb 1, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 1, 2021

References

Based on https://github.com/krassowski/jupyterlab-lsp/pull/498#issuecomment-770464899, backport more changes to the 2.x branch.

Code changes

Backports to 2.x

User-facing changes

Backwards-incompatible changes

Chores

  • linted
  • tested
  • documented
  • changelog entry

@jtpio jtpio mentioned this pull request Feb 1, 2021
@jtpio jtpio marked this pull request as draft February 1, 2021 14:36
@jtpio
Copy link
Member Author

jtpio commented Feb 1, 2021

Setting as draft for now as it looks like there are some compilation issues.

@jtpio
Copy link
Member Author

jtpio commented Feb 1, 2021

This seems to be caused by the use of this.console:

https://github.com/jtpio/jupyterlab-lsp/blob/38e68ffcbf29ba3e87c85fbfa135bcdf95f92609/packages/jupyterlab-lsp/src/adapters/notebook/notebook.ts#L151

The console attribute only seems to be defined on the master branch:

https://github.com/krassowski/jupyterlab-lsp/blob/9c1778dd66354d9431756b7bc65d5fbbae665daf/packages/jupyterlab-lsp/src/adapters/adapter.ts#L95

Defaulting to console.warn in d14af99.

@krassowski krassowski marked this pull request as ready for review February 1, 2021 19:49
@krassowski
Copy link
Member

Thank you!

@krassowski krassowski merged commit 2dbab04 into jupyter-lsp:2.x Feb 1, 2021
@jtpio jtpio deleted the backports-2-x branch February 1, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants