Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Julia language server crashes on too broad save notification #491

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Fix Julia language server crashes on too broad save notification #491

merged 1 commit into from
Jan 24, 2021

Conversation

krassowski
Copy link
Member

References

Fixes #490.

User-facing changes

  • Julia server won't crash on save of non-Julia notebook/file.
  • Performance will increase after save as only relevant connections are being notified
  • Foreign documents will properly receive the save notifications, potentially improving some R language sever functions in %%R cells

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski krassowski merged commit 864efd3 into master Jan 24, 2021
@krassowski krassowski deleted the fix-sendSaved branch February 16, 2021 23:22
@krassowski krassowski added this to the 3.2 milestone Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Julia server hangs after a non-julia file gets saved
1 participant
@krassowski