Completer improvements: kernel type mapping and dynamic documentation #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
<unknown>
if it cannot match a typecompletionItem/resolve
to allow for:completionItem/resolve
completionItem/resolve
toocompletionItem/resolve
; create a PR in the repo that will accept such a contribution (help welcome!)Completer.IRenderer
, for implementation of active item tracking and implements makrdown rendering of documentation inCompleter.IRenderer
CompletionItemTag.Deprecated
Related upstream PR:
Code changes
Added
LazyCompletionItem
class implementingCompletionHandler.ICompletionItem
but also doing much more to workaround the limited flexibility of upstream (see the self-reference trick to workaround jupyterlab/jupyterlab#9643). The new object-oriented code reduced complexity of the completion handler making it considerable more pleasant and enabled implementation ofcompletionItem/resolve
.User-facing changes
completionItem/resolve
retrieved docs for nowcompletionItem/resolve
, e.g. javascript/typescript)Backwards-incompatible changes
Chores