Backport #474 to 2.x #486
Merged
Backport #474 to 2.x #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which were not correctly scoped by path by switching away from id_path which was refactored to not contain the actual file name to uri which does contain the file name and path Add missing wait Co-authored-by: krassowski <[email protected]>
|
Thanks! Do you need any other back-ports for 2.x? |
|
Thanks!
I think only this one. Thanks again for the fix! |
|
btw @krassowski, happy to help cutting a release with this fix. For the 2.x, packages, I guess only pushing to |
|
A release of the 2.x package would be fantastic! |
|
I ran out of open source time last weekend, will look into it tomorrow. |
|
Now released on npm. Please let me know of any issues. Hope it helps! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is a backport of the fix from https://github.com/krassowski/jupyterlab-lsp/pull/474 to the
2.xbranch.Code changes
User-facing changes
Backwards-incompatible changes
Chores