Don't use hardcoded color for fuzzy highlight, show outline when in active line

[krassowski]

References

Fixes #195. I gave up on having a different style for fuzzy matches - it does not seem to be something that others editors do, and there is no reasonable support from the servers for the distinction between fuzzy and exact highlight.

As this still uses the same colour as is used for line highlights, I added a small dotted outline when in the active line.

User-facing changes

When using the dark theme, the fuzzy highlights (as returned by R language server) are now readable and indistinguishable from normal highlights:

There is a very subtle outline added for active line:

Same with the light theme:

Backwards-incompatible changes

None

Chores

• linted
• tested
• documented
• changelog entry

[bollwyvl]

This would still have the problem of using a dark editor theme with a light theme...

…

On Sun, Mar 22, 2020, 06:49 Michał Krassowski ***@***.***> wrote: References Fixes #195 <https://github.com/krassowski/jupyterlab-lsp/issues/195>. I gave up on having a different style for fuzzy matches - it does not seem to be something that others editors do, and there is no reasonable support from the servers for the distinction between fuzzy and exact highlight. As this still uses the same colour as is used for line highlights, I added a small dotted outline when in the active line. User-facing changes When using the dark theme, the fuzzy highlights (as returned by R language server) are now readable and indistinguishable from normal highlights: [image: Screenshot from 2020-03-22 10-33-52] <https://user-images.githubusercontent.com/5832902/77247440-2fd26d00-6c29-11ea-8771-fccc869f4e10.png> [image: Screenshot from 2020-03-22 10-33-42] <https://user-images.githubusercontent.com/5832902/77247441-306b0380-6c29-11ea-8277-5aec36d9d3f9.png> There is a very subtle outline added for active line: [image: Screenshot from 2020-03-22 10-33-21] <https://user-images.githubusercontent.com/5832902/77247442-306b0380-6c29-11ea-848d-58dbfdad699d.png> [image: Screenshot from 2020-03-22 10-33-01] <https://user-images.githubusercontent.com/5832902/77247444-31039a00-6c29-11ea-84fa-7e50cb54f68f.png> Same with the light theme: [image: Screenshot from 2020-03-22 10-32-41] <https://user-images.githubusercontent.com/5832902/77247445-319c3080-6c29-11ea-92e9-782f194f9682.png> [image: Screenshot from 2020-03-22 10-32-19] <https://user-images.githubusercontent.com/5832902/77247446-319c3080-6c29-11ea-9a1c-21a2a268db52.png> [image: Screenshot from 2020-03-22 10-32-08] <https://user-images.githubusercontent.com/5832902/77247447-3234c700-6c29-11ea-996a-889bfed9073a.png> [image: Screenshot from 2020-03-22 10-32-01] <https://user-images.githubusercontent.com/5832902/77247448-32cd5d80-6c29-11ea-85d3-983ce0475cd6.png> Backwards-incompatible changes None Chores - linted - tested - documented - changelog entry ------------------------------ You can view, comment on, or merge this pull request online at: https://github.com/krassowski/jupyterlab-lsp/pull/230 Commit Summary - Don't use hardcoded color for fuzzy highlight, show outline when in active line File Changes - *M* packages/jupyterlab-lsp/style/index.css <https://github.com/krassowski/jupyterlab-lsp/pull/230/files#diff-12aa8ecbcfab0d9d1c9057ff35d7714c> (6) Patch Links: - https://github.com/krassowski/jupyterlab-lsp/pull/230.patch - https://github.com/krassowski/jupyterlab-lsp/pull/230.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/krassowski/jupyterlab-lsp/pull/230>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRFYKLKLH577VZSJKNDRIXUKRANCNFSM4LRH3NRA> .

[krassowski]

Not sure how to reproduce... @bollwyvl do you have a screenshot?

[bollwyvl]

• open atest/examples/example.py

• Settings -> JupyterLab Theme -> JupyterLab Light

• Settings -> Text Editor Theme -> zenburn

• set caret on a token
  

• Settings -> JupyterLab Theme -> JupyterLab Dark

• Settings -> Text Editor Theme -> xq-light

• set caret on a token