Address some issues with positioning system in foreign documents #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
changed the title
19 tasks
|
It seems that we are failing on Linux and Mac (running over 60 minutes), but Windows works ok... |
|
#207 confirms that the fails are not due to changes introduced in this PR. I will proceed as is. |
krassowski
added a commit
that referenced
this pull request
Mar 11, 2020
|
I committed a forgotten piece to master in 84b4db2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#193
Code changes
virtual_shifttoIExtractedCodeextract_argumentstoRegExpForeignCodeExtractorextract_argumentswhich allows to account for the offset (virtual_shift)extract_foreign_codeintochoose_foreign_documentwith benefit to readabilityUser-facing changes
TBD: I will record a gif
Backwards-incompatible changes
Addition of
virtual_shifttheIExtractedCodemight be breaking, but I am not aware of anyone else using this interface.Chores