-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor LSPConnection, ConnectionManager #165
Changes from all commits
a3a5ac5
afc45ac
312c9e5
568234c
48e0a94
99752d3
d8fb97f
8b39f9d
e11a63f
ac82ff0
41c5b0c
e5ec536
1ff5b32
83c1dd8
95eacdf
291e525
bd6442b
32b6a64
93c5067
4ac60a6
548998b
273c9b6
74ebb52
b6df0b7
bbb50d4
505c8a6
c6f9f36
69559b1
79095e6
d9f2605
9c225e6
a995e11
71fc0e7
4d5b112
70d2d39
5ee1427
949407d
1e03f43
792749e
763aa6d
c64556f
2be2b68
4450a0b
74991ec
2d470a1
bbbb4f9
f0d38a1
3249d42
29be129
5763fd4
bcb4e65
2145c42
55bb0d3
d384809
e2a869c
f2a79d6
3fa15ee
8ae1b9e
36aa419
832c7b5
87173e1
452969b
33b1b04
9e7337f
02569d3
7e3bc34
3d45458
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -114,3 +114,4 @@ junit.xml | |
coverage/ | ||
.vscode/ | ||
_schema.d.ts | ||
.virtual_documents/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,9 @@ variables: | |
THIRD_PARTY_LABEXTENSIONS: >- | ||
@krassowski/jupyterlab_go_to_definition | ||
|
||
LINKED_EXTENSIONS: >- | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should have done this ages ago There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's not testing the as-built tarball, but what can you do? that would be an advantage of killing the intermediate layer, as the entire module would be: export import { ConsoleLogger, listen, MessageConnection } from 'vscode-ws-jsonrpc'; ...plus 10 files of boilerplate, and would only need to be updated once an upstream release (if then). |
||
packages/lsp-ws-connection | ||
|
||
jobs: | ||
- template: ci/job.lint.yml | ||
- template: ci/job.test.yml | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seemed to reduce flake a fair amount: on a fresh browser load, the lazy load does make the first connection slower to start, so this time isn't getting rolled up into the aggressive up-front animation waiting.