Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics panel #129

Merged
merged 4 commits into from
Jan 6, 2020
Merged

Diagnostics panel #129

merged 4 commits into from
Jan 6, 2020

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jan 5, 2020

Add diagnostics/inspections panel.

References

Closes #42

Code changes

  • adds jest test for inspections in a notebook
  • adds a few testutilis, moves utilities to testutilis from feature.spec.ts
  • fixes a bug with foreign governments not being updated TODO tests
  • fixes diagnostics being displayed in a wrong document
  • protects from failures in highlights feature (such is a while other story and requires a lot of testing)

User-facing changes

Adds a diagnostics panel. The diagnostics table is scrollable, sortable and a click on the diagnostic moves the user to the relevant place in the notebook or editor.

diagnostics_panel

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski krassowski changed the base branch from rename_syntax_error_ux_workaround to master January 5, 2020 23:42
@krassowski krassowski merged commit 56b3a45 into master Jan 6, 2020
@krassowski krassowski deleted the diagnostics_panel branch March 14, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to display diagnostics results summary in a panel
1 participant