-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build against JupyterLab 4.1, fix tests #1057
Conversation
eaea04a
to
5908adc
Compare
a2fc9a9
to
d20c6a4
Compare
nodeLinker: node-modules | ||
npmRegistryServer: 'https://registry.npmjs.org' | ||
installStatePath: ./build/.cache/yarn/install-state.gz | ||
#globalFolder: ./build/.cache/yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should not be the same as cache folder.
All Windows tests are failing with
|
no-longer needed util workaround
eae77a8
to
fe97658
Compare
reduce verbosity of less important logs which give false positives.
`extensionFactory`
Pressing enter when not needed was leading to test failures due to extra new lines getting added
` Highlights are changed when moving cursor between cells` test
f4c5c83
to
790f2d2
Compare
So we are back at mostly green except for Windows + Python 3.8: I will merge this and create follow-up issues to tackle things to address. Thanks @bollwyvl for starting this! |
References
Builds upon #1052
Code changes
extensionFactory
API (JupyterLab 4.1) to remove workarounds which we used to make it kind of work in Lab 4.0.extensionFactory
is never called for file editors jupyterlab/jupyterlab#15868VirtualDocument
as these were merged upstream and released in 4.1User-facing changes
extensionFactory
API means that:Backwards-incompatible changes
None
Chores