Fix false “undefined name” message caused by cell magic #1007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
In this PR, I want to fix #635.
Code changes
According to the comment in #635, I implemented another transformation to the specific cell magics.
From:
To:
Instead of:
Currently, the target cell magics are hard coded (%%time, %%capture).
It would be better if the list is configurable.
Since I'm new to the project, I need more time to figure out how to make the list configurable, but I will try this in the near future.
User-facing changes
As pointed out in #635, variables defined inside cell magics are not recognized by the lsp, and
undefined name
message shows up.This PR tries to remove these false messages.
Backwards-incompatible changes
No
Chores