Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for code completion and hover settings #376

Closed
quantum-booty opened this issue Sep 25, 2020 · 3 comments
Closed

Documentation for code completion and hover settings #376

quantum-booty opened this issue Sep 25, 2020 · 3 comments

Comments

@quantum-booty
Copy link
Contributor

  1. Is there a setting to disable automatic completion when I press enter? I would like enter to open a new line rather than select an completion.
  2. What are the allowed values for hover key? I tried to set tab as the hover key but it does not work.
@krassowski
Copy link
Member

  1. No unfortunately not in the current version, but this is on the wish list (Display completer if no matches, but do not activate any of the options #350). For the technical reasoning on why we cannot do this just yet see Continuous hinting should not trigger completer if there are no matches #334, Implement a workaround for #334 #335. However, if you can provide a reproducible example demonstrating where it is still a nuisance (still as I already added a workaround to suppress auto-invocation in a typical example demonstrated in Continuous hinting should not trigger completer if there are no matches #334) I will look into this.
  2. Good catch! You can find the allowed values here:

https://github.com/krassowski/jupyterlab-lsp/blob/de32a3ae46db0aeec529f0f157874c3feb75b77e/packages/jupyterlab-lsp/schema/hover.json#L8-L14

It indeed would be better if we could include the enum values in the description field value. Would you like to contribute a fix by editing this file and creating a pull request?

You could also add information on some caveats for the Mac users, as I noted for my previous extension here (and maybe the link to the MDN page which describes to which physical keys they are actually mapped, also in the readme of the previous extension).

@quantum-booty
Copy link
Contributor Author

Thank you @krassowski, I have made a PR.

@quantum-booty
Copy link
Contributor Author

I tested the enter on a simple case of

x=1
x

and autocompletion refused to open a new line. But this scenario would never happen practically. So I am closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants