Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display completer if no matches, but do not activate any of the options #350

Open
krassowski opened this issue Sep 11, 2020 · 0 comments
Open
Labels
enhancement New feature or request feature:completion
Milestone

Comments

@krassowski
Copy link
Member

krassowski commented Sep 11, 2020

The problem

When continuous hinting is enabled, one could stumble upon a completer showing up with all potential suggestions if not match is available; if this happens at the end of a line this poses a problem with the current completer implementation, as the first options is always activated when completer is displayed and this means that hitting Enter with an intent to insert new line will actually select the first completion suggestion (see #334).

How is it done today, and what are the limits of current practice?

This is currently worked around by not showing completer at all in such cases (#335).

Proposed solution

Preferably we would show the completer in all cases, but if there is no suggestion match the we would not activate any completion item (thus avoiding the problem).

How much will it cost?

We probably need a PR into the core to make it happen, and we need to propose a reasonable adjustment in the interfaces first. We probably want this as an optional argument to the trigger action.

Btw, exposing activeItemChanged signal would be useful too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature:completion
Projects
None yet
Development

No branches or pull requests

1 participant