Merge pull request #429 from krassowski/fix-jump-to-schema

Hotfix crash "blank screen" likely related to Mac command character
jupyter-lsp · Dec 16, 2020 · a371da2 · a371da2
2 parents 9577d9a + 674e48c
commit a371da2
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 4 deletions.
diff --git a/.github/workflows/job.test.yml b/.github/workflows/job.test.yml
@@ -14,7 +14,7 @@ defaults:
 env:
   # TODO extract these from files instead
   PY_JLSP_VERSION: 0.9.3
-  JS_JLLSP_VERSION: 2.1.0
+  JS_JLLSP_VERSION: 2.1.1
   JS_JLG2D_VERSION: 1.0.0
 
   PYTHONUNBUFFERED: 1

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,13 @@
 ## CHANGELOG
 
+### `@krassowski/jupyterlab-lsp 2.1.1` (2020-12-15)
+
+- bug fixes
+
+  - fix crash "blank screen" caused by Mac command character included in jump-to schema file ([#429])
+
+[#429]: https://github.com/krassowski/jupyterlab-lsp/issues/429
+
 ### `jupyter-lsp 0.9.3` (2020-12-13)
 
 - features

diff --git a/packages/jupyterlab-lsp/package.json b/packages/jupyterlab-lsp/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@krassowski/jupyterlab-lsp",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "description": "Language Server Protocol integration for JupyterLab",
   "keywords": [
     "jupyter",

diff --git a/packages/jupyterlab-lsp/schema/jump_to.json b/packages/jupyterlab-lsp/schema/jump_to.json
@@ -10,7 +10,7 @@
       "type": "string",
       "enum": ["Alt", "Control", "Shift", "Meta", "AltGraph", "Accel"],
       "default": "Alt",
-      "description": "Keyboard key which needs to be pressed with click to jump. The allowed keys are Alt, Control, Shift, Accel, and AltGraph. Accel corresponds to Control or Meta (⌘ Command on Mac). Linux user: Meta key is also supported. Safari users: Meta key is also supported, AltGraph is not supported. To see which physical keys are mapped, visit: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/getModifierState"
+      "description": "Keyboard key which needs to be pressed with click to jump. The allowed keys are Alt, Control, Shift, Accel, and AltGraph. Accel corresponds to Control or Meta (Command on Mac). Linux user: Meta key is also supported. Safari users: Meta key is also supported, AltGraph is not supported. To see which physical keys are mapped, visit: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/getModifierState"
     }
   },
   "jupyter.lab.shortcuts": [

diff --git a/packages/metapackage/package.json b/packages/metapackage/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@krassowski/jupyterlab-lsp-metapackage",
-  "version": "2.1.0",
+  "version": "2.1.1",
   "description": "JupyterLab LSP - Meta Package. All of the packages used by JupyterLab LSP",
   "homepage": "https://github.com/krassowski/jupyterlab-lsp",
   "bugs": {