Performance: only check old_mode if needed

jupyter-lsp · Oct 25, 2020 · 83ce87a · 83ce87a
1 parent 6f34d91
commit 83ce87a
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/packages/jupyterlab-lsp/src/features/syntax_highlighting.ts b/packages/jupyterlab-lsp/src/features/syntax_highlighting.ts
@@ -77,11 +77,10 @@ export class CMSyntaxHighlighting extends CodeMirrorIntegration {
           continue;
         }
 
-        let old_mode = editor.getOption('mode');
-
         // change the mode if the majority of the code is the foreign code
         if (coverage > this.settings.composite.foreignCodeThreshold) {
           editors_with_current_highlight.add(ce_editor);
+          let old_mode = editor.getOption('mode');
           if (old_mode != mode.mime) {
             editor.setOption('mode', mode.mime);
           }