Merge pull request #928 from krassowski/fix-mark-highlight-in-dark-mode

Fix contrast of mark highlights in dark mode
jupyter-lsp · Apr 17, 2023 · 661b743 · 661b743
2 parents 08b6afb + 7cf24a9
commit 661b743
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/packages/jupyterlab-lsp/style/signature.css b/packages/jupyterlab-lsp/style/signature.css
@@ -1,3 +1,13 @@
-.lsp-signature-help pre code {
+.lsp-signature-help code {
   font-size: var(--jp-code-font-size);
 }
+
+.lsp-signature-help code > mark {
+  color: var(--jp-lsp-signature-mark-color);
+  background: var(--jp-lsp-signature-mark-background);
+}
+
+.lsp-signature-help code > mark > span {
+  /* override syntax highlight colour to ensure contrast */
+  color: var(--jp-lsp-signature-mark-color) !important;
+}
diff --git a/packages/jupyterlab-lsp/style/variables/base.css b/packages/jupyterlab-lsp/style/variables/base.css
@@ -18,4 +18,7 @@
   /* hover */
   --jp-editor-mirror-lsp-hover-decoration-style: dotted;
   --jp-editor-mirror-lsp-hover-decoration-color: var(--jp-brand-color1);
+  /* signature */
+  --jp-lsp-signature-mark-color: black;
+  --jp-lsp-signature-mark-background: yellow;
 }
diff --git a/packages/jupyterlab-lsp/style/variables/jupyterlab-dark.css b/packages/jupyterlab-lsp/style/variables/jupyterlab-dark.css
@@ -1,3 +1,8 @@
 body[data-jp-theme-light='false'] .cm-s-jupyter {
   --jp-editor-mirror-lsp-highlight-background-color: rgba(151, 173, 255, 0.3);
 }
+
+body[data-jp-theme-light='false'] {
+  --jp-lsp-signature-mark-color: white;
+  --jp-lsp-signature-mark-background: #607e01;
+}