-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💥 Role / Directive Refactor #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwkoch
force-pushed
the
feat/markdown-it-myst
branch
from
February 8, 2023 02:57
83c1406
to
e7fd48e
Compare
rowanc1
reviewed
Feb 8, 2023
I think that the only bugs that are left are around the card headers. It would be great to have tests on the remaining directives, but also want to get this in and out the door! I think there is another pass on validation we need to do, but that can come in next, I don't think we actually loose that much? |
Some known things:
Anything else? I think those can easily come in a validation pass. |
rowanc1
force-pushed
the
feat/markdown-it-myst
branch
from
February 16, 2023 21:04
a502ba2
to
0b062d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markdown-it-myst
is a new package to generically parse roles/directives into tokens. It does a nested parse to tokenize args/options/content as well, passing along both the raw role/directive content and the tokenized content.This package does not define custom role/directive types; those are defined downstream as AST transforms on content made available here.
This package is the first step in addressing #181
Update
This PR has consolidated the work on
markdown-it-myst
withmyst-parser
#193 andmyst-roles/directives
#206 - it addresses all the refactoring described in #181