-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 More typst export improvements #1665
Conversation
🦋 Changeset detectedLatest commit: d87637f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to keep the current functionality if there is empty link text.
packages/myst-to-typst/src/index.ts
Outdated
const next = nextCharacterIsText(parent, node); | ||
state.write(next ? `#[@${id}]` : `@${id}`); | ||
state.write(`#link(<${id}>)[`); | ||
state.renderChildren(node); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means myst is doing the enumeration. I don't totally love that, but I think it is fine for now.
I think that in the future, we should not fun the filling enumeration transform, and do the default @${id}
if there are no children.
@@ -35,4 +35,4 @@ cases: | |||
- type: text | |||
value: 'a for the first part of the figure!' | |||
typst: |- | |||
See #[@fig1]a for the first part of the figure! | |||
See #link(<fig1>)[]a for the first part of the figure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this actually is the case where we want this to continue happening with an @id
now.
Right now this is empty link text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, yeah, I was thinking about this - wasn't sure if we wanted MyST default text or typst default text. Thanks for fixing it up!
This PR just has a handful of typst improvements from working on formatting a PDF export:
Newly supported small typst features include:
Areas where typst now matches other myst exports better:
[see here](#fig1)
will render as "see here" in typst instead of the default "Figure 1")Areas where it is easier to customize typst: