Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI #193

Closed
wants to merge 2 commits into from
Closed

Fix failing CI #193

wants to merge 2 commits into from

Conversation

GlobalMin
Copy link
Contributor

Hi @agoose77 👋 .

I noticed the current main branch is failing due to a linting error, which is my first commit of the two here. Then there is an error stemming from this line in the workflow.yml GH actions file:

python -c 'from packaging.version import Version; from importlib.metadata import version as version_of; raise SystemExit(Version(version_of('\''jupyterlab'\'')) > Version('\''4.0.6'\''))'

This I'm less sure how the EB team wants to handle but I modified the max version > Version('\''4.0.6'\'')) to > Version('\''4.0.7'\'')) since that's the latest jupyterlab version and this constraint in pyproject.toml will install the latest 4.x.x version.

"python -m pip install 'jupyterlab>=4.0.0,<5'"

Anyway fixes the CI on my fork. Let me know if any issues with these changes.

Jameson

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch GlobalMin/jupyterlab-myst/main

@GlobalMin
Copy link
Contributor Author

@rowanc1 @agoose77 - any thoughts on this?

@rowanc1 rowanc1 added the maintenance Improvements or additions to infrastructure label Oct 24, 2023
@rowanc1
Copy link
Collaborator

rowanc1 commented Oct 24, 2023

Linting change looks good. This gets broken every time we release, and we haven't figured out how to change the release infrastructure or patch it before it is committed.

Not sure on the other version change if @agoose77 has specific thoughts there?

@GlobalMin
Copy link
Contributor Author

Linting change looks good. This gets broken every time we release, and we haven't figured out how to change the release infrastructure or patch it before it is committed.

Not sure on the other version change if @agoose77 has specific thoughts there?

Sounds good. So this line is what the second change addresses: https://github.com/executablebooks/jupyterlab-myst/blob/4684bc358f7d9be3fe62baccc862c35606c9c488/.github/workflows/build.yml#L46

I'm not sure why tests fail without this patch but when you pip install jupyterlab currently it's going to install 4.0.7.

@GlobalMin
Copy link
Contributor Author

@agoose77 bumping for visibility

@agoose77
Copy link
Collaborator

@GlobalMin thanks for the contribution! I've fixed this separately now, but I appreciate your contribution immensely!

@agoose77 agoose77 closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improvements or additions to infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants