[Blocked by #127] GH-125: Update assumptions and correct type handling. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwelz3
added
bug
|
This makes the InteractiveViewer widget a bit nicer to use for mixed types |
zwelz3
commented
May 10, 2022
| @@ -189,7 +195,7 @@ def assign_css_classes(self): | |||
| color_list = COLOR_LIST.copy() | |||
| n_to_add = len(self.uri_to_string_type.keys()) - len(color_list) | |||
| if n_to_add > 0 and self.allow_large_graphs: | |||
| color_list.extend([(255, 255, 255)] * n_to_add) | |||
There was a problem hiding this comment.
This was white and made the nodes basically invisible
zwelz3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously assume the only type in the InteractiveViewer is rdf:type. This ticket adds in the handling of rdfs:subClassOf and handles mixed typing for instances (ignores owl:NamedIndividual)
Closes #125