Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSR-12 as default Rule Set #181

Closed
iudizm opened this issue Jul 29, 2022 · 5 comments
Closed

Use PSR-12 as default Rule Set #181

iudizm opened this issue Jul 29, 2022 · 5 comments

Comments

@iudizm
Copy link

iudizm commented Jul 29, 2022

Hi @junstyle, wouldn't it be better to change the default value of the rule set to be "@PSR12" instead of "@PSR2" ?

"As of 2019-08-10 PSR-2 has been marked as deprecated. PSR-12 is now recommended as an alternative."

-- https://www.php-fig.org/psr/psr-2/

junstyle pushed a commit that referenced this issue Aug 1, 2022
@junstyle
Copy link
Owner

junstyle commented Aug 1, 2022

ok, updated

@iudizm
Copy link
Author

iudizm commented Aug 1, 2022

nice, thanks

@iudizm iudizm closed this as completed Aug 1, 2022
@lunaneff
Copy link

lunaneff commented Sep 6, 2022

It'd be even better to change it to @PER. Right now, PER only contains the PSR12 rules, but since PER is an evolving standard, it's better to have it now already and automatically have new rules be applied as they're added

@iudizm
Copy link
Author

iudizm commented Sep 8, 2022

@laurinneff I agree that @PER is a great idea to cover the new changes being made to PHP.

But, in my opinion, 'Evolving Recommendations' aren't the best to set as default rules, if you take in consideration that the extension will fix the code following the current recommendations.
I think the default rule set should be the last defined Standard Recommendations for coding style

junstyle pushed a commit that referenced this issue Sep 9, 2022
3. a new setting for setting a tmp dir;  #189 #187

if no tmp dir setted, will try `system tmp dir` and `current user home dir`
@junstyle
Copy link
Owner

junstyle commented Sep 9, 2022

already set to @per in new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants