Skip to content

Commit

Permalink
Skip tensorflow test test_forward_ssd (apache#10231)
Browse files Browse the repository at this point in the history
Since this test is launched in a thread, errors aren't propagated up to the main thread and thusly pytest doesn't detect / report them, so this test will always succeed. Given that this single test can take [upwards of 30 minutes](https://ci.tlcpack.ai/job/tvm/job/main/2499/testReport/cython.tests.python.frontend.tensorflow/test_forward/), this PR disables it until someone lands a proper fix (given that this test takes so long some consideration should be given to reducing its runtime before enabling it again).

Co-authored-by: driazati <[email protected]>
  • Loading branch information
driazati and driazati authored Feb 12, 2022
1 parent 8c125ca commit 77fcd14
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tests/python/frontend/tensorflow/test_forward.py
Original file line number Diff line number Diff line change
Expand Up @@ -3934,6 +3934,9 @@ def _test_ssd_impl():
tvm.testing.assert_allclose(tvm_output[i], tf_output[i], rtol=1e-3, atol=1e-3)


@pytest.mark.skip(
reason="Use of threading module here hides errors, see https://github.com/apache/tvm/pull/10231"
)
def test_forward_ssd():
run_thread = threading.Thread(target=_test_ssd_impl, args=())
old_stack_size = threading.stack_size(100 * 1024 * 1024)
Expand Down

0 comments on commit 77fcd14

Please sign in to comment.