feat: use addr_of! instead to create a raw pointer
#714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❯ npm run build:console
warning: creating a shared reference to mutable static is discouraged
--> src/libs/storage/src/store.rs:91:13
|
91 | &NEXT_BATCH_ID,
| ^^^^^^^^^^^^^^ shared reference to mutable static
|
= note: for more information, see issue #114447 rust-lang/rust#114447
= note: this will be a hard error in the 2024 edition
= note: this shared reference has lifetime
'static, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior= note:
#[warn(static_mut_refs)]on by defaulthelp: use
addr_of!instead to create a raw pointer|
91 | addr_of!(NEXT_BATCH_ID),
| ~~~~~~~~~~~~~~~~~~~~~~~
warning: creating a shared reference to mutable static is discouraged
--> src/libs/storage/src/store.rs:139:21
|
139 | &NEXT_CHUNK_ID,
| ^^^^^^^^^^^^^^ shared reference to mutable static
|
= note: for more information, see issue #114447 rust-lang/rust#114447
= note: this will be a hard error in the 2024 edition
= note: this shared reference has lifetime
'static, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behaviorhelp: use
addr_of!instead to create a raw pointer|
139 | addr_of!(NEXT_CHUNK_ID),
| ~~~~~~~~~~~~~~~~~~~~~~~