index: merge of index fails

[abingham]

Over on issue #50 on the google codesearch project I've been trying to sort out a problem where cindex fails to properly merge index files on windows. Someone over there said that you might be interested in addressing this problem, so here I am.

The main issue as far as I can tell is that the merge algorithm mmap's a few files but doesn't unmmap them. As a result, windows fails to overwrite the original index with the merged index (i.e. because the original index is mmap'd and, thus, apparently not writable). My diagnosis may well be incorrect in some details, but I'm pretty certain that cindex is unable to overwrite the original index.

Could you perhaps look at this and verify that I'm at least on the right track? And do you have any suggestions on how to best resolve this? I'm a newbie with go, but this feels like something that should be easy to address in the right hands.

[abingham]

Ah...I should have looked at your code first! It appears that you've already addressed this. I'll go ahead and close this. Thanks!