-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
index: merge of index fails #50
Comments
I'm seeing this precise behavior as well. Windows Server 2012 RS Datacenter. Go version go1.5.2 windows/amd64. |
I've looked into this a bit, and the proximal problem seems to be that the
I'm no go expert (or even novice), but I dug into the merge code a bit, and it appears that the index file is being accessed through a mmap (see I'm happy to help sort this out, but I'm a bit out of my depth with go here, and I don't really have a lot of time to devote to this...I would just like codesearch to work! Any ideas? |
A bit more digging. The The unmapping support appears to be provided by go in the form of |
@dgryski You seem to be keeping an eye on this repository. If I put in the time to make a patch for this, what are the chances that it'll be merged in? There doesn't seem to be a lot of life in this project, and I'd rather not spin my wheels for nothing. |
I unfortunately don't have a commit bit here, so I can't merge any fixes in :( However there is at least one other fork with activity that would appreciate the patch: https://github.com/junkblocker/codesearch And having the patch attached as a PR to this repository means when/if somebody with a commit bit does pay attention, it's easy to merge. |
Thanks for the pointer; I've taken the issue up over there. If a patch gets created, I'll see what I can do about getting it over here, too. It seems reasonable that everything on that fork might flow this way. |
This issue has actually already been resolved over on junkblocker's fork. |
Yes I saw the same issue on Windows 10 and can confirm that junkblocker's fork fixes it. |
I've tried to index the Go sources on Windows. The first run of Cindex is like expected. The second run doesn't remove
.csearchindex~
and has created a second file.csearchindex~~
. I don't know whether the merge of.csearchindex
and.csearchindex~
has been successful.The expected behaviour is
.csearchindex
and.csearchindex~
will be merged and.csearchindex~
will removed.OS: Windows 7
Go: go1.5rc1
First Run
Second Run
The text was updated successfully, but these errors were encountered: