Handle null value for target

juniwalk · May 17, 2024 · b12ef0c · b12ef0c
1 parent 88a8736
commit b12ef0c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/Entity/Record.php b/src/Entity/Record.php
@@ -130,14 +130,21 @@ public function getMessageTranslated(Translator $translator): Stringable|string
 	}
 
 
-	public function setTarget(object $target, mixed $targetId = null): void
+	public function setTarget(?object $target, mixed $targetId = null): void
 	{
+		if (is_null($target)) {
+			$this->targetId = null;
+			$this->target = null;
+
+			return;
+		}
+
 		if (!$targetId && $target instanceof Identified) {
 			$targetId ??= $target->getId();
 		}
 
-		$this->target = $target::class;
 		$this->targetId = $targetId;
+		$this->target = $target::class;
 
 		if ($target instanceof Proxy && $targetParent = get_parent_class($target)) {
 			$this->target = $targetParent;

diff --git a/src/RecordBuilder.php b/src/RecordBuilder.php
@@ -30,7 +30,7 @@
  * 		note?: ?string,
  * 		finished?: bool,
  * 		event?: ?string,
- * 		target?: object,
+ * 		target?: ?object,
  * 		owner?: ?Identity,
  * 		params?: array<string, mixed>,
  * }
@@ -134,7 +134,7 @@ public function withEvent(?string $event): static
 	}
 
 
-	public function withTarget(object $target): static
+	public function withTarget(?object $target): static
 	{
 		if ($target instanceof ParamsProvider) {
 			$this->withParams($target->getRecordParams());