Introduce lambda based timeout assertions #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@junit-team/junit-lambda, please let me know your thoughts on the PR. |
| * <em>Asserts</em> that execution of the supplied {@code executable} | ||
| * completes before the given {@code timeout} is exceeded. | ||
| * | ||
| * <p>Note: the executable will be executed in the same thread as that |
There was a problem hiding this comment.
nit: space between "as" and "that". same for other timeout methods
There was a problem hiding this comment.
good catch! (y)
I'll fix it.
sbrannen
force-pushed
the
issues/438-assert-timeout
branch
6 times, most recently
from
2309eda to
a7e71d8
Compare
This commit introduces assertTimeout() methods in Assertions that support both lazy and preemptive timeouts for blocks of code supplied as lambda expressions. For example, the following assertion would pass: assertTimeout(ofMillis(500), () -> Thread.sleep(10)); Whereas, the following assertion would fail: assertTimeout(ofMillis(10), () -> Thread.sleep(500)); The above examples execute the code block in the same thread as the caller. To perform the same assertions and have the code executed in a separate thread and then preemptively aborted, the above can be rewritten as follows. assertTimeoutPreemptively(ofMillis(10), () -> Thread.sleep(500)); Issue: #438
sbrannen
force-pushed
the
issues/438-assert-timeout
branch
from
a7e71d8 to
0759a68
Compare
|
Looks good to me! Great to finally have support for timeouts! 👍 |
|
Thanks for the review, and... I couldn't agree more: it definitely is great to finally have official support for timeouts in JUnit 5! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit introduces
assertTimeout()methods inAssertionsthat support both lazy and preemptive timeouts for blocks of code supplied as lambda expressions.For example, the following assertion would pass:
assertTimeout(ofMillis(500), () -> Thread.sleep(10));Whereas, the following assertion would fail:
assertTimeout(ofMillis(10), () -> Thread.sleep(500));The above examples execute the code block in the same thread as the caller. To perform the same assertion as the last example and have the code executed in a separate thread and then preemptively aborted, the above can be rewritten as follows.
assertTimeoutPreemptively(ofMillis(10), () -> Thread.sleep(500));Issue: #438
I hereby agree to the terms of the JUnit Contributor License Agreement.