-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ExtensionPointConfiguration #135
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Current coverage is
|
jlink
force-pushed
the
issue112-positions
branch
8 times, most recently
from
January 29, 2016 15:56
b31a3e3
to
78a711c
Compare
jlink
force-pushed
the
issue112-positions
branch
from
February 4, 2016 08:50
78a711c
to
69597b7
Compare
jlink
force-pushed
the
issue112-positions
branch
from
February 5, 2016 13:26
a176225
to
bf5517e
Compare
2 tasks
This was referenced Mar 15, 2016
I'm closing this issue since we've decided not to ship any support for extension ordering in M1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to tackle some of the points discussed in #112 .
Every concrete subtype of
ExtensionPoint
can now register a configuration of typeExtensionPointConfiguration
. For example:This configuration is used in
ExtensionRegistry
two things:Position
when registering an extension. All other values will lead to anExtensionConfigurationException
.The concept has been introduced, because not all values make sense for all types of extension points. For example,
ExceptionHandlerExtensionPoint
allowsFIRST
,DEFAULT
andLAST
.Extension point types that do not come with their own configuration only allow
DEFAULT
as position and are thus ordered by their position in the source only.