Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ExtensionContext Namespace API #1013

Merged
merged 1 commit into from
Aug 10, 2017

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Aug 9, 2017

Overview

This PR removes the method getStore() from the ExtensionContext interface and renames Namespace.DEFAULT to Namespace.GLOBAL.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

This PR removes the method getStore() from the ExtensionContext
interface and renames Namespace.DEFAULT to Namespace.GLOBAL.
@ghost ghost assigned sormuras Aug 9, 2017
@ghost ghost added the status: in progress label Aug 9, 2017
@sormuras sormuras added this to the 5.0 RC3 milestone Aug 9, 2017
@sormuras sormuras mentioned this pull request Aug 9, 2017
7 tasks
Copy link
Member

@kcooney kcooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is sample code in the usage guide that uses getStore()

@sormuras
Copy link
Member Author

A full-text search for getStore() yields no result and all 25 occurences (in 13 files) of getStore do not refer to the deleted method.

Do you have a specific usage guide sample in mind?

@sbrannen sbrannen merged commit 46a3aff into master Aug 10, 2017
@ghost ghost removed the status: in progress label Aug 10, 2017
@sbrannen
Copy link
Member

This has been merged into master.

Thanks, guys!

@sormuras sormuras deleted the extension-context-api-cleanup branch August 10, 2017 14:30
Andrei94 pushed a commit to Andrei94/junit5 that referenced this pull request Jun 23, 2018
This PR removes the method getStore() from the ExtensionContext
interface and renames Namespace.DEFAULT to Namespace.GLOBAL.

Issue: junit-team#1013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants