-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kotlin Sequence
support for @TestFactory
methods
#3376
Comments
hanszt
changed the title
Add kotlin sequence support for @testfactory methods
Add kotlin Sequence support for @TestFactory annotated methods
Jul 2, 2023
6 tasks
6 tasks
Team decision: Add convention-based conversion to |
marcphilipp
added
type: enhancement
theme: programming model
component: Jupiter
component: Kotlin
up-for-grabs
status: new
and removed
status: new
labels
Jul 7, 2023
Thanks for the feedback. I implemented the requested changes in this pullrequest |
hanszt
pushed a commit
to hanszt/junit5
that referenced
this issue
May 27, 2024
Examples of benefits: - Kotlin Sequence support for @testfactory - Kotlin Sequence support for @MethodSource - Classes that expose an Iterator returning method, can be converted to a stream. Issue: junit-team#3376 I hereby agree to the terms of the JUnit Contributor License Agreement.
sbrannen
changed the title
Add kotlin Sequence support for @TestFactory annotated methods
Add Kotlin Jun 2, 2024
Sequence
support for @TestFactory
methods
hanszt
pushed a commit
to hanszt/junit5
that referenced
this issue
Sep 27, 2024
Examples of benefits: - Kotlin Sequence support for @testfactory - Kotlin Sequence support for @MethodSource - Classes that expose an Iterator returning method, can be converted to a stream. Issue: junit-team#3376 I hereby agree to the terms of the JUnit Contributor License Agreement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Overview
It would be nice if you could write something like this in Kotlin when working with JUnit Jupiter.
Currently you have to add
.toIterable()
as an extra line to make it work with JUnit Jupiter.The Kotlin
Sequence
class is an example of an iterator providing class, but it is not anIterable
. That's why it does not work as return type for@TestFactory
methods at the moment.A benefit of adding this at this low level is that, Kotlin Sequences, or any other
Iterator
orSpliterator
providing class can now also be used in other JUnit Jupiter methods where an object from an annotated method needs to be converted to a stream.I have an implementation for it ready. see:
Suggestion
All tests still pass.
I would like to contribute to JUnit 5 and make a pull request for this branch, but I don't have push permission yet for a feature branch in the JUnit 5 project.
Could you please be so kind to take a look at the suggestion I provided?
Thanks in advance! I'm awaiting your response :)
Deliverables
org.junit.platform.commons.util.CollectionUtils
.Spliterator
providing classes to a stream inorg.junit.platform.commons.util.CollectionUtils
.The text was updated successfully, but these errors were encountered: