Fixes #67 no since javadoc #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewfarwell, does this address all of my comments and @kcooney's from the last pull? |
|
Yep, Takes everything into account. I've just done another commit, because I missed something. |
|
Looks good to me. @kcooney, do you want one more look? |
|
LGTM
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the contents of maven jars, added the javadoc tag since to all of the classes, using the earliest version in which the class appeared. If there was no jar in which it appeared, I assumed 4.11.
If there was no javadoc comment for a class, I added it, but only containing the since.
I did not do the junit.framework classes, or experimental classes, or internal.