Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Categories (issue #307) #354

Merged
merged 0 commits into from
Jul 14, 2012
Merged

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Oct 29, 2011

This is the implementation for a feature of Configurable Categories
https://github.com/KentBeck/junit/issues/307

You can make a narrow list of tests in your build process according to build specifics.
See the test CategoriesConfiguredBySystemPropertiesTest.
There the suite accepts almost all tests of platforms, and the system properties suppress some of them.

Here we use a Set of categories which was necessary in this feature. Not using single values in variables fIncluded either fExcluded in Categories class. See their comments in code.

This way we have built also a prerequisite for #336.

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JUnit style is explicit imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i can do this.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Oct 31, 2011

To be discussed:
file name form "com/Category1.java" : comma separated + slashes is normal maven-surefire style
NO_CATEGORIES empty array

(reasons answered in previous comments)

@Tibor17
Copy link
Contributor Author

Tibor17 commented Feb 27, 2012

Hi David,

I saw your update in #340. I would like to participate on that proposal as well, because this feature can go on only if the multiple categories is applicable to it.

BR, Tibor

@dsaff
Copy link
Member

dsaff commented Apr 17, 2012

OK, waiting to review until things settle down on #142

@dsaff
Copy link
Member

dsaff commented Jul 12, 2012

OK, getting ready to restart review on this pull. Can you make sure the patch still applies to HEAD without merge conflicts?

@Tibor17
Copy link
Contributor Author

Tibor17 commented Jul 12, 2012

i will check it in two hours

@Tibor17
Copy link
Contributor Author

Tibor17 commented Jul 12, 2012

all is up-to-date, you can replace the sources

@dsaff
Copy link
Member

dsaff commented Jul 12, 2012

@Tibor17, github is still telling me it doesn't cleanly merge with KentBeck/master. Can you pull KentBeck/master, resolve conflicts, and push? Thanks.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Jul 13, 2012

@dsaff I will resolve it tomorrow.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Jul 14, 2012

@dsaff
My GIT commands closed this pull.
I created #461 instead of this one.
'IncludeExcludeCategory should accept many categories + configurable'

@Tibor17 Tibor17 mentioned this pull request Sep 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants