-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable Categories (issue #307) #354
Conversation
import java.util.ArrayList; | ||
import java.util.Arrays; | ||
import java.util.List; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JUnit style is explicit imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i can do this.
To be discussed: (reasons answered in previous comments) |
Hi David, I saw your update in #340. I would like to participate on that proposal as well, because this feature can go on only if the multiple categories is applicable to it. BR, Tibor |
OK, waiting to review until things settle down on #142 |
OK, getting ready to restart review on this pull. Can you make sure the patch still applies to HEAD without merge conflicts? |
i will check it in two hours |
all is up-to-date, you can replace the sources |
@Tibor17, github is still telling me it doesn't cleanly merge with KentBeck/master. Can you pull KentBeck/master, resolve conflicts, and push? Thanks. |
@dsaff I will resolve it tomorrow. |
This is the implementation for a feature of Configurable Categories
https://github.com/KentBeck/junit/issues/307
You can make a narrow list of tests in your build process according to build specifics.
See the test CategoriesConfiguredBySystemPropertiesTest.
There the suite accepts almost all tests of platforms, and the system properties suppress some of them.
Here we use a Set of categories which was necessary in this feature. Not using single values in variables fIncluded either fExcluded in Categories class. See their comments in code.
This way we have built also a prerequisite for #336.