4.10 - Recursive temp folders #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rodolfoliviero, it looks like this pull caused a breakage: #441. Do you have time to submit a fix? Thanks. |
|
I was totally wrong on this. I reviewed the test cases for TemporaryFolder and the implementation of newFolder(String[]) and found that I had misread it. I am profoundly disappointed in my attitude in dealing with this and my lack of due diligence in reviewing my (faulty) conclusions before ranting and raving here. My sincerest apologies to the community and @rodolfoliviero in particular. I will not make a repeat of this behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sending commits range to branch 4.10