Improve message if file exists instead of folder #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npathai
approved these changes
Oct 27, 2018
npathai
reviewed
Oct 27, 2018
| continue; | ||
| } else if (file.exists()) { | ||
| throw new IOException( | ||
| "a file with the path \'" + relativePath.getPath() + "\' exists"); |
There was a problem hiding this comment.
We can include already in the message, as createNewFile includes it in error message.
There was a problem hiding this comment.
I was thinking about the word "already" for this message two. But it is wrong here because the user wants to create a folder and not a file. Therefore we cannot say the file is already there.
Closed
marcphilipp
requested changes
Oct 31, 2018
| "could not create a folder with the path \'" + relativePath.getPath() + "\'"); | ||
| if (!lastMkdirsCallSuccessful) { | ||
| if (file.exists() && file.isDirectory()) { | ||
| continue; |
There was a problem hiding this comment.
I think we could avoid the continue by moving the !file.isDirectory() back into the enclosing if and remove the first inner if.
There was a problem hiding this comment.
You're right. Fixed.
When TemporaryFolder(String path) or TemporaryFolder(String... paths) is called with a path that matches the path of an existing file then an IOException with a message like "a file with path <path> exists" is thrown.
stefanbirkner
force-pushed
the
temporary-folder-file-exists
branch
from
3e6be76 to
10a863e
Compare
marcphilipp
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
TemporaryFolder(String path)orTemporaryFolder(String... paths)iscalled with a path that matches the path of an existing file then an
IOExceptionwith a message like "a file with path exists" isthrown.