-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new feature to let test methds in a class run as user specified order #1527
Conversation
Thanks for the contribution. I am hoping we could include #1130 in 4.13, which is a more general and flexible way to solve this problem. With that pull, you could create a custom |
@kcooney Thanks for your comment. Notice: This feature in this PR has the same behavior as another unit test framework TestNG. This is a convenient way as my experience.
|
I'm curious what the other maintainers think. @junit-team/junit-committers While adding an attribute is convenient, I would prefer we don't merge this pull for 4.13, for these reasons:
|
Momentarily delurking to say that I think it would be good for the JUnit design if @FixMethodOrder was used less and less, not more and more. (Basically everything @kcooney said.) |
@JacobCN if Ordering is added in 4.13 then I will probably deprecate |
Got it, I close this PR now. |
FWIW I agree that we should rather get #1130 merged so this can be implemented as an extension. |
This is a new feature to let JUnit run as you specified order. What we need do is two steps:
This feature is an optional featue to let JUnit users specify method order in some special scenarios.
More details please refer to the comments in changed code.