Made ExpectedException.isAnyExceptionExpected public

[jokaah]

Is there any harm in making this method public?

I have a base class for our test classes that has both an ExpectedException rule and a Verifier rule. The problem is that I don't want to run the Verifier if any exception is expected. So this is my current solution:

public abstract class TestBase {
    private Method isAnyExceptionExpected;

    public TestBase() throws Exception {
        this.isAnyExceptionExpected = ExpectedException.class.getDeclaredMethod("isAnyExceptionExpected");
        this.isAnyExceptionExpected.setAccessible(true);
    }

    @Rule
    public ExpectedException thrown = ExpectedException.none();

    @Rule
    public Verifier verifier = new Verifier() {
        @Override
        public void verify() {
            try {
                if (!(boolean) isAnyExceptionExpected.invoke(thrown)) {
                    verifyStuff();
                    verifyOtherStuff();
                    alsoVerifyThis();
                }
            } catch (IllegalAccessException | InvocationTargetException e) {
                System.err.print("Reflection exception: " + e.getMessage());  // ugh...
            }
        }
    };

    @Before
    public void beforeEach() throws Exception {
        doAwesomeSetup();
    }
}

[kcooney]

While I can't think of any problems, I think any user of JUnit 4.13 that uses Java 8 should use expectThrows() or assertThrows() instead of ExpectExceptoon

[kcooney]

Let's make this final

[kcooney]

Add @since 4.13