Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@BeforeParam/@AfterParam for Parameterized runner #1435

Merged
merged 18 commits into from
Apr 21, 2017
Merged

@BeforeParam/@AfterParam for Parameterized runner #1435

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
066e1d6
@BeforeParam/@AfterParam for Parameterized runner
panchenko Apr 1, 2017
45064f7
Fix minor style issues
kcooney Apr 16, 2017
3390335
test for multiple @BeforeParam/@AfterParam
panchenko Apr 18, 2017
1de2311
test for @BeforeParam/@AfterParam with multiple parameters
panchenko Apr 18, 2017
15ac6ad
Validate number of parameters in @BeforeParam/@AfterParam
panchenko Apr 18, 2017
70245b3
code style
panchenko Apr 18, 2017
e270f2c
iterate parameters once
panchenko Apr 19, 2017
570ec30
style changes
panchenko Apr 19, 2017
754732b
Style fixes
kcooney Apr 19, 2017
35bbd8f
Make RunnersFactory.parameterCount final
kcooney Apr 20, 2017
301a6e0
Add test cases for @Parameters methods returning Collection
kcooney Apr 20, 2017
98e061a
reuse RunBefores/RunAfters
panchenko Apr 20, 2017
f406970
style
panchenko Apr 20, 2017
f7e3ad3
javadoc for @BeforeParam/@AfterParam
panchenko Apr 20, 2017
76c1779
update javadoc
panchenko Apr 20, 2017
03e598f
update header in javadoc
panchenko Apr 20, 2017
4958ea8
javadoc: "parameters"
panchenko Apr 20, 2017
ab15e7e
since 4.13
panchenko Apr 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/org/junit/runners/Parameterized.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,19 @@
* }
* </pre>
*
* <h3>Executing code before/after executing tests for a specific parameter</h3>
* <p>
* If your test needs to perform some preparation or cleanup based on the parameters this can be
* done by adding public static methods annotated with &#064;BeforeParam/&#064;AfterParam,
* such methods should either have no parameters or have same parameters as the test.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace this paragraph with:

 * If your test needs to perform some preparation or cleanup based on the
 * parameters, this can be done by adding public static methods annotated with
 * {@code @BeforeParam}/{@code @AfterParam}. Such methods should either have no
 * parameters or the same parameters as the test.

* <pre>
* &#064;BeforeParam
* public static void beforeTestsForParameter(String onlyParameter) {
* System.out.println("Testing " + onlyParameter);
* }
* </pre>
* </p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the </p> line.

*
* <h3>Create different runners</h3>
* <p>
* By default the {@code Parameterized} runner creates a slightly modified
Expand Down