Ignore bridge methods when scanning for annotated methods. #1413
Conversation
kcooney
force-pushed
the
ignore-bridge-methods
branch
3 times, most recently
from
5107244 to
5c3287d
Compare
kcooney
force-pushed
the
ignore-bridge-methods
branch
from
5c3287d to
01d0b44
Compare
| @@ -149,6 +149,11 @@ public boolean isShadowedBy(FrameworkMethod other) { | |||
| } | |||
|
|
|||
| @Override | |||
| boolean isBridgeMethod() { | |||
There was a problem hiding this comment.
@kcooney -- i found an use-case where "isBridge()" is not enough. I think, it should be widened to "isSynthetic()". See https://github.com/junit-team/junit5/compare/ignore_synthetic_methods with a test case included.
There was a problem hiding this comment.
JUnit4 doesn't support using @Test, @Before etc on anything but "normal" methods.
There was a problem hiding this comment.
...and JUnit 4 does not provide support tools like JUnit 5 now does.
There was a problem hiding this comment.
@kcooney Is the assumption correct, that every bridge method is also synthetic? Couldn't find a definitive answer to that question in the language spec or via googling, yet.
There was a problem hiding this comment.
@sormuras synthetic methods are any methods introduced by the compiler that do not correspond to something in the source (with the exception of default constructors and static initializers). Therefore any bridge method is a synthetic method.
This is one possible fix for #1411
The other possible fix is #1412