Add public CategoryFilter constructor that was removed in JUnit 4.12 #1403
Conversation
kcooney
force-pushed
the
CategoryFilter-constructor
branch
3 times, most recently
from
a1e22da to
6ec5c8d
Compare
| final Set<Class<?>> set= new HashSet<Class<?>>(); | ||
| if (t != null) { | ||
| Collections.addAll(set, t); | ||
| private static Set<Class<?>> createSet(Class<?>[] t) { |
There was a problem hiding this comment.
While you're at it, can you please rename t to something with a little more meaning?
|
|
||
| return t.length == 1 | ||
| ? Collections.<Class<?>>singleton(t[0]) | ||
| : new HashSet<Class<?>>(Arrays.asList(t)); |
There was a problem hiding this comment.
How about a LinkedHashSet so the iteration order stays intact?
There was a problem hiding this comment.
The previous code used HashSet for this case. I don't think ordering matters, since these are inclusion/exclusion filters. Am I missing something?
There was a problem hiding this comment.
You're right: The ordering doesn't really matter. In general, I like to preserve it whenever possible so it's easier to debug/test and to not confuse users with a different order in error messages. However, in this case using HashSet should be fine.
There was a problem hiding this comment.
Good point about debugging. The toString() and describe() methods do print out the categories. Printing them in the same order makes sense. Changed to use LinkedHashSet in a separate commit
| included = createSet(inclusions); | ||
| excluded = createSet(exclusions); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it possible to remove the duplication in these constructors by having only a single private one that does the assignments?
There was a problem hiding this comment.
I think doing that would sacrifice readability
This makes describe() and toString() print the categories in the same order that they were provided to the user.
kcooney
force-pushed
the
CategoryFilter-constructor
branch
from
6ec5c8d to
07bd583
Compare
…unit-team#1403) * Add back public CategoryFilter constructor that was removed in JUnit 4.12. * Remove duplicated code that handles null categories. * Change CategoryFilter to use LinkedHashSet(). This makes describe() and toString() print the categories in the same order that they were provided to the user.
…unit-team#1403) * Add back public CategoryFilter constructor that was removed in JUnit 4.12. * Remove duplicated code that handles null categories. * Change CategoryFilter to use LinkedHashSet(). This makes describe() and toString() print the categories in the same order that they were provided to the user.
Note that this constructor was removed in #503