-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ordering, Orderable and @OrderWith #1130
Merged
+1,292
−56
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
44b64df
Add Ordering, Orderable and @OrderWith.
kcooney e68c015
Remove unreachable code
kcooney 4770fff
Handle @RunWith in RunnerBuilder
kcooney a19a3ab
Change Sorter to no longer extend Ordering.
kcooney 82e019f
Revert "Change Sorter to no longer extend Ordering."
kcooney f19f035
Replace Ordering.order(List) with Ordering.orderDescription(Description)
kcooney 8390bc7
Rename GenericOrdering to GeneralOrdering
kcooney 6e38776
Merge branch 'master' into ordering
kcooney 1ba37d2
Add Ordering.Context so Orderings can use the Description to get
kcooney 62ca6a0
Rename parameters in applyOrdering() and Sorter.apply() from "runner"…
kcooney 753842d
Check ordering correctness in Ordering.
kcooney ea71fa4
Pass Ordering.Context in constructor when reflectively creating insta…
kcooney 121744f
Remove unnecessary call to unmodifableCollection()
kcooney 9d71b2f
Remove use of ReflectiveOperationException
kcooney 5a7186b
Merge branch 'master' into ordering
kcooney 2f9d21a
Fix javadoc for orderWith()
kcooney c6de86d
Minor formatting fixes
kcooney 5a3f954
Add Ordering.Factory.
kcooney f2f6131
Merge branch 'master' into ordering
kcooney 4ce52c1
Add missing @since Javadoc for Ordering methods
kcooney d8a1ee6
Merge branch 'master' into ordering
kcooney bfbad94
Minor formatting fix.
kcooney 9fb4772
Merge branch 'master' into ordering
kcooney 78ee8c6
Rename ComparsionBasedOrdering to ComparatorBasedOrdering; fix Javadoc
kcooney 9d1e2aa
Rename GeneralOrdering to Orderer and make it no longer implement Ord…
kcooney 550654a
Add OrderingRequest, to ensure orderWith() orders once
kcooney b2ce86a
Introduce MemoizingRequest
kcooney ca3e040
Sort tests in AllManipulationTests
kcooney 3e6d464
Removed Comparators.reverse(); it's broken and the JDK provides a bet…
kcooney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Check ordering correctness in Ordering.
This allows us to optimize Ordering.shuffledBy, and makes it easier for custom runners to be orderable.
commit 753842d6bc429b11e57d33a6b7a9a67abff559bc
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a comment to document what this method is used for?