refactor: define failureCountIs in terms of failureCount

junit-team · May 13, 2016 · 9b1bc4a · 9b1bc4a
1 parent e5e47b3
commit 9b1bc4a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/src/main/java/org/junit/experimental/results/ResultMatchers.java b/src/main/java/org/junit/experimental/results/ResultMatchers.java
@@ -5,6 +5,8 @@
 import org.hamcrest.Matcher;
 import org.hamcrest.TypeSafeMatcher;
 
+import static org.hamcrest.Matchers.equalTo;
+
 /**
  * Matchers on a PrintableResult, to enable JUnit self-tests.
  * For example:
@@ -34,16 +36,7 @@ public static Matcher<PrintableResult> isSuccessful() {
      * Matches if there are {@code count} failures
      */
     public static Matcher<PrintableResult> failureCountIs(final int count) {
-        return new TypeSafeMatcher<PrintableResult>() {
-            public void describeTo(Description description) {
-                description.appendText("has " + count + " failures");
-            }
-
-            @Override
-            public boolean matchesSafely(PrintableResult item) {
-                return item.failureCount() == count;
-            }
-        };
+        return failureCount(equalTo(count));
     }
 
     /**

diff --git a/src/test/java/org/junit/tests/experimental/results/ResultMatchersTest.java b/src/test/java/org/junit/tests/experimental/results/ResultMatchersTest.java
@@ -12,10 +12,11 @@
 import static org.junit.Assert.assertThat;
 
 public class ResultMatchersTest {
+
     @Test
     public void hasFailuresHasGoodDescription() {
         assertThat(ResultMatchers.failureCountIs(3).toString(),
-                is("has 3 failures"));
+                is("has a number of failures matching <3>"));
     }
 
     @Theory