gh-action-test

.github/workflows/lint.yaml

@@ -0,0 +1,44 @@
+name: "lint"
+
+on:
+  pull_request:
+    types: ["opened", "reopened"]
+  push:
+  schedule:
+    # Run at midnight UTC every day with 15 minutes delay added to avoid high load periods
+    - cron: "15 0 * * *"
+  workflow_dispatch:
+
+permissions:
+  # So the workflow can cancel in-progress jobs
+  actions: "write"
+
+concurrency:
+  group: "${{github.workflow}}-${{github.ref}}"
+  # Cancel in-progress jobs for efficiency
+  cancel-in-progress: true
+
+jobs:
+  lint-check:
+    runs-on: "ubuntu-latest"
+    permissions:
+      # So `eslint-annotate-action` can create / update status checks
+      checks: "write"
+      # So `eslint-annotate-action` can get pull request files
+      contents: "read"
+    steps:
+      - uses: "actions/checkout@v4"
+        with:
+          submodules: "recursive"
+      - uses: "actions/setup-node@v4"
+        with:
+          node-version: 22
+      - run: "npm --prefix new-log-viewer/ clean-install"
+      - run: "npm --prefix new-log-viewer/ run lint:ci"
+        continue-on-error: true
+      - uses: "ataylorme/eslint-annotate-action@v3"
+        with:
+          fail-on-error: true
+          fail-on-warning: true
+          only-pr-files: true
+          report-json: "./new-log-viewer/eslint-report.json"

new-log-viewer/package.json

@@ -5,6 +5,10 @@
   "main": "src/index.tsx",
   "scripts": {
     "build": "webpack --config webpack.prod.js",
+    "lint": "npm run lint:check",
+    "lint:ci": "npm run lint:check -- --output-file eslint-report.json --format json",
+    "lint:check": "eslint src webpack.*.js",
+    "lint:fix": "npm run lint:check -- --fix",
     "start": "webpack serve --open --config webpack.dev.js"
   },
   "repository": {

new-log-viewer/src/App.tsx

@@ -3,6 +3,8 @@
 import UrlContextProvider from "./contexts/UrlContextProvider";
 
 
+// TODO: violation 1
+
 /**
  * Renders the main application.
  *

new-log-viewer/src/components/Editor/MonacoInstance/utils.ts

@@ -41,6 +41,7 @@ const createMonacoEditor = (
     const editor = monaco.editor.create(
         editorContainer,
         {
+            // eslint-disable-next-line no-warning-comments
             // TODO: Add custom observer to debounce automatic layout
             automaticLayout: true,
             maxTokenizationLineLength: 30_000,

new-log-viewer/src/components/Layout.tsx

@@ -29,8 +29,9 @@
     getLastItemNumInPrevChunk,
 } from "../utils/math";
 import Editor from "./Editor";
 import {goToPositionAndCenter} from "./Editor/MonacoInstance/utils";
 
+// TODO: violation
 
 const formFields = [
     {

new-log-viewer/src/contexts/StateContextProvider.tsx

@@ -95,6 +95,23 @@ const getLastLogEventNum = (beginLineNumToLogEventNum: BeginLineNumToLogEventNum
     return lastLogEventNum;
 };
 
+/**
+ * Sends a post message to a worker with the given code and arguments. This wrapper around
+ * `worker.postMessage()` ensures type safety for both the request code and its corresponding
+ * arguments.
+ *
+ * @param worker
+ * @param code
+ * @param args
+ */
+const workerPostReq = <T extends WORKER_REQ_CODE>(
+    worker: Worker,
+    code: T,
+    args: WorkerReq<T>
+) => {
+    worker.postMessage({code, args});
+};
+
 /**
  * Provides state management for the application. This provider must be wrapped by
  * UrlContextProvider to function correctly.
@@ -116,13 +133,6 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
 
     const mainWorkerRef = useRef<null|Worker>(null);
 
-    const mainWorkerPostReq = useCallback(<T extends WORKER_REQ_CODE>(
-        code: T,
-        args: WorkerReq<T>
-    ) => {
-        mainWorkerRef.current?.postMessage({code, args});
-    }, []);
-
     const handleMainWorkerResp = useCallback((ev: MessageEvent<MainWorkerRespMessage>) => {
         const {code, args} = ev.data;
         console.log(`[MainWorker -> Renderer] code=${code}`);
@@ -138,6 +148,7 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
                 setNumEvents(args.numEvents);
                 break;
             case WORKER_RESP_CODE.NOTIFICATION:
+                // eslint-disable-next-line no-warning-comments
                 // TODO: notifications should be shown in the UI when the NotificationProvider
                 //  is added
                 console.error(args.logLevel, args.message);
@@ -156,15 +167,14 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
             new URL("../services/MainWorker.ts", import.meta.url)
         );
         mainWorkerRef.current.onmessage = handleMainWorkerResp;
-        mainWorkerPostReq(WORKER_REQ_CODE.LOAD_FILE, {
+        workerPostReq(mainWorkerRef.current, WORKER_REQ_CODE.LOAD_FILE, {
             fileSrc: fileSrc,
             pageSize: getConfig(CONFIG_KEY.PAGE_SIZE),
             cursor: cursor,
             decoderOptions: getConfig(CONFIG_KEY.DECODER_OPTIONS),
         });
     }, [
         handleMainWorkerResp,
-        mainWorkerPostReq,
     ]);
 
     // Synchronize `logEventNumRef` with `logEventNum`.
@@ -183,7 +193,7 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
 
     // On `logEventNum` update, clamp it then switch page if necessary or simply update the URL.
     useEffect(() => {
-        if (URL_HASH_PARAMS_DEFAULT.logEventNum === logEventNum) {
+        if (null === mainWorkerRef.current || URL_HASH_PARAMS_DEFAULT.logEventNum === logEventNum) {
             return;
         }
 
@@ -202,7 +212,7 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
                 // NOTE: We don't need to call `updateLogEventNumInUrl()` since it's called when
                 // handling the `WORKER_RESP_CODE.PAGE_DATA` response (the response to
                 // `WORKER_REQ_CODE.LOAD_PAGE` requests) .
-                mainWorkerPostReq(WORKER_REQ_CODE.LOAD_PAGE, {
+                workerPostReq(mainWorkerRef.current, WORKER_REQ_CODE.LOAD_PAGE, {
                     cursor: {code: CURSOR_CODE.PAGE_NUM, args: {pageNum: newPageNum}},
                     decoderOptions: getConfig(CONFIG_KEY.DECODER_OPTIONS),
                 });
@@ -213,7 +223,6 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
     }, [
         numEvents,
         logEventNum,
-        mainWorkerPostReq,
     ]);
 
     // On `filePath` update, load file.

new-log-viewer/src/index.tsx

@@ -6,6 +6,8 @@
 import "./index.css";
 
 
+// TODO: violation 2
+
 // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 const root = createRoot(document.getElementById("root")!);
 root.render(

new-log-viewer/src/services/LogFileManager.ts

@@ -16,6 +16,8 @@
 import JsonlDecoder from "./decoders/JsonlDecoder";
 
 
+// TODO: violation 4 - this should interrupt the check for violation 3
+
 /**
  * Loads a file from a given source.
  *
@@ -32,6 +34,7 @@
         fileName = getBasenameFromUrlOrDefault(fileSrc);
         fileData = await getUint8ArrayFrom(fileSrc, () => null);
     } else {
+        // eslint-disable-next-line no-warning-comments
         // TODO: support file loading via Open / Drag-n-drop
         throw new Error("Read from file not yet supported");
     }

new-log-viewer/src/services/MainWorker.ts

@@ -12,6 +12,9 @@
 import LogFileManager from "./LogFileManager";
 
 
+// TODO: violation 3 - i will push another one soon so the check for this commit would not finish
+
+
 /* eslint-disable import/no-named-as-default-member */
 dayjs.extend(dayjsUtc);
 dayjs.extend(dayjsTimezone);

new-log-viewer/src/services/decoders/JsonlDecoder.ts

@@ -82,6 +82,7 @@ class JsonlDecoder implements Decoder {
             return null;
         }
 
+        // eslint-disable-next-line no-warning-comments
         // TODO We could probably optimize this to avoid checking `#invalidLogEventIdxToRawLine` on
         // every iteration.
         const results: DecodeResultType[] = [];

new-log-viewer/src/services/formatters/LogbackFormatter.ts

@@ -154,6 +154,7 @@ class LogbackFormatter implements Formatter {
      * @return The formatted string.
      */
     #formatVariables (formatString: string, logEvent: JsonObject): string {
+        // eslint-disable-next-line no-warning-comments
         // TODO These don't handle the case where a variable value may contain a '%' itself
         for (const key of this.#keys) {
             if (false === (key in logEvent)) {