fix: compare (#18)

* fix: compare
jungvengers · Mar 4, 2023 · 9f0f361 · 9f0f361
1 parent 95437fe
commit 9f0f361
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/server/src/club/club.service.ts b/packages/server/src/club/club.service.ts
@@ -40,7 +40,7 @@ export class ClubService {
 
   async update(admin: Admin, id: number, updateClubDto: UpdateClubDto) {
     const item = await this.clubRepository.findOneBy({ id });
-    if (admin.role !== 'admin' && compare(admin.role, item?.name)) {
+    if (admin.role !== 'admin' && !compare(admin.role, item?.name)) {
       throw new HttpException('Not admin of club', HttpStatus.UNAUTHORIZED);
     }
     return this.clubRepository.update(id, updateClubDto);

diff --git a/packages/server/src/form/form.service.ts b/packages/server/src/form/form.service.ts
@@ -31,7 +31,7 @@ export class FormService {
     if (!club) {
       throw new HttpException('Club not found', HttpStatus.NOT_FOUND);
     }
-    if (admin.role !== 'admin' && compare(admin.role, club?.name)) {
+    if (admin.role !== 'admin' && !compare(admin.role, club?.name)) {
       throw new HttpException('Not admin of club', HttpStatus.UNAUTHORIZED);
     }
     const item = {
@@ -48,7 +48,7 @@ export class FormService {
     if (!club) {
       throw new HttpException('Club not found', HttpStatus.NOT_FOUND);
     }
-    if (admin.role !== 'admin' && compare(admin.role, club?.name)) {
+    if (admin.role !== 'admin' && !compare(admin.role, club?.name)) {
       throw new HttpException('Not admin of club', HttpStatus.UNAUTHORIZED);
     }
     const item = {

diff --git a/packages/server/src/project/project.service.ts b/packages/server/src/project/project.service.ts
@@ -18,7 +18,7 @@ export class ProjectService {
   ) {}
 
   async create(admin: Admin, createProjectDto: CreateProjectDto) {
-    if (admin.role !== 'admin' && compare(admin.role, createProjectDto.club)) {
+    if (admin.role !== 'admin' && !compare(admin.role, createProjectDto.club)) {
       throw new HttpException('Not admin of club', HttpStatus.UNAUTHORIZED);
     }
     const project = this.projectRepository.create(createProjectDto);
@@ -57,7 +57,7 @@ export class ProjectService {
   }
 
   async update(admin: Admin, id: number, updateProjectDto: UpdateProjectDto) {
-    if (admin.role !== 'admin' && compare(admin.role, updateProjectDto.club)) {
+    if (admin.role !== 'admin' && !compare(admin.role, updateProjectDto.club)) {
       throw new HttpException('Not admin of club', HttpStatus.UNAUTHORIZED);
     }
     if (admin.role !== 'admin') {
@@ -72,7 +72,7 @@ export class ProjectService {
 
   async remove(admin: Admin, id: number) {
     const item = await this.projectRepository.findOneBy({ id });
-    if (admin.role !== 'admin' && compare(admin.role, item?.club)) {
+    if (admin.role !== 'admin' && !compare(admin.role, item?.club)) {
       throw new HttpException('Not admin of club', HttpStatus.UNAUTHORIZED);
     }
     return this.projectRepository.delete(id);