fix: support comments in FZF_DEFAULT_OPTS_FILE by sanitizing content #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Fixes: #3961 Added a sanitization step to the `FZF_DEFAULT_OPTS_FILE` processing, allowing users to include comments in their configuration. The sanitizer skips empty lines and lines starting with a `#`, inserting the remaining options into a buffer that will be passed to the parser. Inline comments are not supported. Additionally, any argument that includes a `#` should remain unaffected by this change.
|
Thanks, but I'm afraid this won't be able to handle cases like this: FZF_DEFAULT_OPTS='--header "# world
# peace"'I wonder if it's possible to extend mattn/go-shellwords to trim comments from the input. |
|
Ahh, that is rather obscure but understandable. Perhaps I'll go look over there when I get some more time, thanks anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a sanitization step to the
FZF_DEFAULT_OPTS_FILEprocessing, allowing users to include comments in their configuration.The sanitizer skips empty lines and lines starting with a
#, inserting the remaining options into a buffer that will be passed to the parser.Inline comments are not supported. Additionally, any argument that includes a
#should remain unaffected by this change.