Skip to content

Commit

Permalink
rollback 9aa1bba!
Browse files Browse the repository at this point in the history
  • Loading branch information
june07 committed May 29, 2024
1 parent bbe9a3d commit ed81752
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 11 deletions.
4 changes: 2 additions & 2 deletions manifest.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"manifest_version": 3,
"name": "__MSG_appName__",
"version": "3.6.12",
"version": "3.6.13",
"default_locale": "en",
"description": "__MSG_appDescription__",
"author": "June07 <[email protected]> (https://june07.com/)",
Expand Down Expand Up @@ -76,5 +76,5 @@
]
},
"short_name": "__MSG_appShortName__",
"version_name": "3.6.12"
"version_name": "3.6.13"
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nimv3",
"version": "3.6.12",
"version": "3.6.13",
"scripts": {
"dev": "vite --host",
"dev:extension": "npm-run-all --parallel build:dev watch:rollup:deps",
Expand Down
9 changes: 1 addition & 8 deletions src/sw.js
Original file line number Diff line number Diff line change
Expand Up @@ -439,13 +439,6 @@ function createTabOrWindow(url, info, socket) {
}
})
}
async function groupHasNonDeadTabs(groupId) {
// if the group only contains something other than the dead tab alone
const group = await chrome.tabGroups.get(groupId)
const window = await chrome.windows.get(group.windowId, { populate: true })
const tabsExcludingDeadOnes = window.tabs.filter(tab => Object.values(cache.deadSocketSessions)?.find(session => session.tabId !== tab.id))
return tabsExcludingDeadOnes.length > 0
}
async function group(tabId) {
googleAnalytics.fireEvent('group', {})
try {
Expand All @@ -462,7 +455,7 @@ async function group(tabId) {
state.groups['default'] = untrackedGroup
amplitude.getInstance().logEvent('Program Event', { action: 'Tab Group Added', detail: 'external' })
}
if (state.groups['default'] && await groupHasNonDeadTabs(state.groups['default'].id)) {
if (state.groups['default']) {
chrome.tabs.group({ tabIds: tabId, groupId: trackedDefaultGroup?.id || state.groups['default'].id })
} else {
try {
Expand Down

0 comments on commit ed81752

Please sign in to comment.